From 272b9c899824353b4c61d633d00dd7541b9c40ce Mon Sep 17 00:00:00 2001
From: karina <karinyash96@gmail.com>
Date: Sat, 2 May 2026 22:43:32 +0400
Subject: [PATCH] chore: general cleanup in code (removed unused includes and
 cosmetic stuff

---
 Kernel/Include/Arch/GIC.h       | 1 -
 Kernel/Include/Arch/Timer.h     | 6 ++++--
 Kernel/Include/VM/Heap.h        | 2 +-
 Kernel/Include/VM/PMM.h         | 1 -
 Kernel/Include/VM/VMM.h         | 3 ++-
 Kernel/Source/Arch/DTB.c        | 1 -
 Kernel/Source/Arch/Exceptions.c | 2 --
 Kernel/Source/VM/Heap.c         | 2 +-
 Kernel/Source/VM/PMM.c          | 6 +++---
 Kernel/Source/VM/VMM.c          | 2 +-
 10 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/Kernel/Include/Arch/GIC.h b/Kernel/Include/Arch/GIC.h
index 1f06c56..a89b26f 100644
--- a/Kernel/Include/Arch/GIC.h
+++ b/Kernel/Include/Arch/GIC.h
@@ -1,6 +1,5 @@
 #pragma once
 #include <Types.h>
-#include <Arch/IO.h>
 #include <Arch/Exceptions.h>
 
 enum {
diff --git a/Kernel/Include/Arch/Timer.h b/Kernel/Include/Arch/Timer.h
index 4951a05..f9fb0e4 100644
--- a/Kernel/Include/Arch/Timer.h
+++ b/Kernel/Include/Arch/Timer.h
@@ -2,8 +2,10 @@
 #include <Types.h>
 #include <Arch/Exceptions.h>
 
-static const UInt64 kTimerFrequency = 1000; // 1ms
-static const UInt8 kTimerIRQ = 27;
+enum {
+    kTimerFrequency = 1000, // 1ms
+    kTimerIRQ = 27,
+};
 
 void TimerInitialize();
 void TimerReset(UInt64 interval);   
diff --git a/Kernel/Include/VM/Heap.h b/Kernel/Include/VM/Heap.h
index c76a94d..da04352 100644
--- a/Kernel/Include/VM/Heap.h
+++ b/Kernel/Include/VM/Heap.h
@@ -15,7 +15,7 @@ typedef struct  __attribute__((aligned(16))) VMHeapBlockHeader {
     struct VMHeapBlockHeader* next;
     struct VMHeapBlockHeader* previous;
     UInt64 size;
-    bool isFree;
+    Boolean isFree;
 } VMHeapBlockHeader;
 
 void HeapInitialize();
diff --git a/Kernel/Include/VM/PMM.h b/Kernel/Include/VM/PMM.h
index cd45223..e7eb1e4 100644
--- a/Kernel/Include/VM/PMM.h
+++ b/Kernel/Include/VM/PMM.h
@@ -1,6 +1,5 @@
 #pragma once
 #include <Types.h>
-#include "../Common/bootinfo.h"
 
 enum {
     kVMPageSize = 4096,
diff --git a/Kernel/Include/VM/VMM.h b/Kernel/Include/VM/VMM.h
index 1b6d0b9..568763d 100644
--- a/Kernel/Include/VM/VMM.h
+++ b/Kernel/Include/VM/VMM.h
@@ -25,11 +25,12 @@ enum {
     kVMKernelVMA   = 0xFFFFFFFF80000000,
     kHHDMOffset    = 0xFFFF888000000000,
     kVMFbVirtBase  = 0xFFFFFFFFFC000000,
+    kKernelPhysBase = 0x40100000,
 };
 
 
 static inline Address VMKernelVirtToPhys(Address virt) {
-    return virt - 0xFFFFFFFF80100000 + 0x40100000; // TODO: hardcode is awful
+    return virt - 0xFFFFFFFF80100000 + kKernelPhysBase;
 }
 
 static inline Address VMPhysToHHDM(Address phys) {
diff --git a/Kernel/Source/Arch/DTB.c b/Kernel/Source/Arch/DTB.c
index 9d638a2..c57cfeb 100644
--- a/Kernel/Source/Arch/DTB.c
+++ b/Kernel/Source/Arch/DTB.c
@@ -1,6 +1,5 @@
 #include <Arch/DTB.h>
 #include <OS/Panic.h>
-#include <OS/Log.h>
 #include <Lib/Bytes.h>
 #include <Lib/Align.h>
 #include <Lib/String.h>
diff --git a/Kernel/Source/Arch/Exceptions.c b/Kernel/Source/Arch/Exceptions.c
index 20692ad..70f3a1e 100644
--- a/Kernel/Source/Arch/Exceptions.c
+++ b/Kernel/Source/Arch/Exceptions.c
@@ -1,7 +1,5 @@
 #include <Arch/Exceptions.h>
-#include <Arch/CPU.h>
 #include <Arch/GIC.h>
-#include <IO/Serial.h>
 #include <OS/Panic.h>
 
 Address ExceptionsHandler(ExceptionsContext* frame, ExceptionsType type) {
diff --git a/Kernel/Source/VM/Heap.c b/Kernel/Source/VM/Heap.c
index a230b16..6735e55 100644
--- a/Kernel/Source/VM/Heap.c
+++ b/Kernel/Source/VM/Heap.c
@@ -10,7 +10,7 @@ static void CombineForward(VMHeapBlockHeader* current) {
     if (!current->next || !current->next->isFree) return;
     current->size += sizeof(VMHeapBlockHeader) + current->next->size;
     current->next = current->next->next;
-    if (current->next) current->next->previous = current; // what the fuck
+    if (current->next) current->next->previous = current;
 }
 
 void HeapInitialize() {
diff --git a/Kernel/Source/VM/PMM.c b/Kernel/Source/VM/PMM.c
index e346d48..723d3c0 100644
--- a/Kernel/Source/VM/PMM.c
+++ b/Kernel/Source/VM/PMM.c
@@ -54,9 +54,9 @@ void PMMInitialize(VMBootMemoryMap* bootMap) {
         Size pagesToReserve = (regionSize + kVMPageSize - 1) / kVMPageSize;
 
         for (Size p = 0; p < pagesToReserve; p++) {
-            Address pageAdress = regionBase + (p * kVMPageSize);
-            if (pageAdress >= sPMMRamBase && pageAdress < (sPMMRamBase + bootMap->totalRAM.size)) {
-                BitmapSet(sPMMBitmap, pageAdress);
+            Address pageAddress = regionBase + (p * kVMPageSize);
+            if (pageAddress >= sPMMRamBase && pageAddress < (sPMMRamBase + bootMap->totalRAM.size)) {
+                BitmapSet(sPMMBitmap, pageAddress);
             }
         }
     }
diff --git a/Kernel/Source/VM/VMM.c b/Kernel/Source/VM/VMM.c
index ccbf659..1d7bc05 100644
--- a/Kernel/Source/VM/VMM.c
+++ b/Kernel/Source/VM/VMM.c
@@ -159,7 +159,7 @@ void VMMInitialize(VMBootMemoryMap* bootMap, Bootinfo* info) {
     Size kernelSize = ((Address)_kernelEnd - (Address)_kernelStart) + pmmBitmapSize;
     kernelSize = (kernelSize + kVMPageSize - 1) & ~(kVMPageSize - 1); 
 
-    Address kernelPhysStart = 0x40100000; // TODO: hardcode is awful
+    Address kernelPhysStart = kKernelPhysBase;
 
     for (Address offset = 0; offset < kernelSize; offset += kVMPageSize) {
         Address phys = kernelPhysStart + offset;